Codecov Report

Merging #3779 (26ad8bd) into master (02dabb8) will increase coverage by 0.12%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #3779      +/-   ##
==========================================
+ Coverage    0.06%    0.18%   +0.12%     
==========================================
  Files         301      302       +1     
  Lines      276555   277126     +571     
==========================================
+ Hits          179      512     +333     
- Misses     276376   276614     +238     

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Thanks for finding this @sergey-shandar --

I'd suggest just deleting that line from costs/mod.rs instead:

diff --git a/clarity/src/vm/costs/mod.rs b/clarity/src/vm/costs/mod.rs
index ee9a1a6eb..c70ab9600 100644
--- a/clarity/src/vm/costs/mod.rs
+++ b/clarity/src/vm/costs/mod.rs
@@ -18,7 +18,6 @@ use std::collections::{BTreeMap, HashMap};
 use std::convert::{TryFrom, TryInto};
 use std::{cmp, fmt};
 
-use regex::internal::Exec;
 use rusqlite::types::{FromSql, FromSqlResult, ToSql, ToSqlOutput, ValueRef};
 use serde::{Deserialize, Serialize};

The Exec method isn't used anywhere, so we can just remove that import and then we don't need to version pin regex.

Just put the full version. Humans look at the cargo.toml file to determine dependencies, not the cargo.lock. The full version removes ambiguity.

This PR doesn't touch the Cargo.toml at all right now (because there was a spurious import that could just be removed to solve the issue), and I'd suggest that it stay that way.

If you want to talk about changing the way the blockchain does version specifications in the toml file, that's probably better done in an issue for changing that in the contributing guide.

@kantai is it ok that the PR is open against the master branch? Do we sync changes from the master to the develop and next branches?

@kantai is it ok that the PR is open against the master branch?

Yes -- for changes that don't touch any code (e.g., docs only, github workflows, etc.) it's okay to merge to master. This PR, because it just removes an unused import, is okay.

Do we sync changes from the master to the develop and next branches?

Yes, changes to master should always be merged back into develop and next. There isn't an automated process for this in the github repository.